search

bitcoinjs / coinselect

An unspent transaction output (UTXO) selection module for bitcoin.
MIT License
179 stars 101 forks source link

fees can be <1 sat/B but bigger than 0 sat/B #32

Open karelbilek opened 6 years ago

karelbilek commented 6 years ago

I am not sure how well is the code handling fees smaller than 1sat/B

For example DASH regularly has those fees and there is no reason why bitcoin couldn't have that

(yes, I know code in this repo is old and I sort of gave up on helping you with it :( but I noticed this issue now )

dcousens commented 6 years ago

@karel-3d did you have an example of what you mean?

karelbilek commented 6 years ago

In all the fixtures, the feerate can be 0.1 (or 1.1 or 2.1 etc)

I am not sure if the library will handle it well. It probably will? It should be added to tests though, all feeRates are always numbers and bigger than 1

Here etc

https://github.com/bitcoinjs/coinselect/blob/master/test/fixtures/index.json#L4

dcousens commented 6 years ago

Ok. Let's test decimal fee rates :)