search

bitcoinjs / coinselect

An unspent transaction output (UTXO) selection module for bitcoin.
MIT License
180 stars 101 forks source link

fix: treat zero value outputs as pre-defined #71

Closed kaladinlight closed 2 years ago

kaladinlight commented 2 years ago

Previously, outputs with a value of 0 were being treated as a split output. This change only treats outputs with a value of undefined as split outputs. This allows you to pass through a zero value script (OP_RETURN) output into the coinselect split function without it increasing the splitOutputsCount, resulting in a correct and expected result.

junderw commented 2 years ago

Please rebase (added Github Actions and package-lock etc.)

kaladinlight commented 2 years ago

Please rebase (added Github Actions and package-lock etc.)

should be up to date now

junderw commented 2 years ago

published as 3.1.13

kaladinlight commented 2 years ago

published as 3.1.13

Thanks for getting this in and published so quickly!