search

bitcoinjs / fast-dat-parser

Superfast blockchain parser for stats
MIT License
74 stars 26 forks source link

Makefile fixes #19

Closed ddustin closed 5 years ago

ddustin commented 5 years ago

The Makefile was failing on OSX. Not sure if the extra slash is OSX specific so this update just filters out both cases.

dcousens commented 5 years ago

@ddustin this, this doesn't look right?

ddustin commented 5 years ago

@dcousens Here is the exact error I got when compiling master with this commit: f956214cd5b3b66fe53ca3aeb36e9c9710b76773

$ make g++-8 -pedantic -std=c++1z -W -Wall -Wcast-qual -Wconversion -Werror -Wextra -Wwrite-strings -Wno-unused-function -O3 -Iinclude -MMD -MP -c src//bestchain.cpp -o src//bestchain.o g++-8 -pedantic -std=c++1z -W -Wall -Wcast-qual -Wconversion -Werror -Wextra -Wwrite-strings -Wno-unused-function -O3 -Iinclude -MMD -MP -c src//parser.cpp -o src//parser.o g++-8 src//bestchain.o src//parser.o -lcrypto -O3 -o bestchain duplicate symbol _main in: src//bestchain.o src//parser.o ld: 1 duplicate symbol for architecture x86_64 collect2: error: ld returned 1 exit status make: *** [bestchain] Error 1

ddustin commented 5 years ago

Found a cleaner solution and posted it here: https://github.com/bitcoinjs/fast-dat-parser/pull/20