search

bitcoinjs / indexd

An external bitcoind index management service module
ISC License
53 stars 23 forks source link

adds tipHeight function #19

Closed deweller closed 6 years ago

deweller commented 6 years ago

This is something that I found useful

dcousens commented 6 years ago

Hmmm, wait adapter already exposes tip... shrug

deweller commented 6 years ago

adapter and blockchain already expose a tip function. But this function returns only the block hash and not the entire tip object.

Changing this to return the entire tip object would be ideal, but it would break some other dependencies on the tip function so it would be a more complicated task.

I think I would prefer tip to return the entire tip object (height and blockId) - but that would be a breaking change and would require more work.

dcousens commented 6 years ago

I think I would prefer tip to return the entire tip object (height and blockId) - but that would be a breaking change and would require more work.

Agreed.

ACK as is for now :+1: