search

bitcoinjs / tiny-secp256k1

A tiny secp256k1 native/JS wrapper
MIT License
92 stars 55 forks source link

Critical dependency: the request of a dependency is an expression #14

Closed orpheus closed 6 years ago

orpheus commented 6 years ago

WARNING in ./node_modules/bindings/bindings.js 81:43-53 Critical dependency: the request of a dependency is an expression @ ./node_modules/tiny-secp256k1/index.js @ ./node_modules/bip32/index.js @ ./node_modules/oip-hdmw/lib/Coin.js @ ./node_modules/oip-hdmw/lib/index.js @ ./node_modules/oip-account/lib/Account.js @ ./node_modules/oip-account/lib/index.js @ ./src/App.js @ ./src/index.js @ multi (webpack)-dev-server/client?http://127.0.0.1:9156 ./src/index.js

Is there anything wrong in this export? 

//tiny-secp256k1/index.js
'use strict'

try 
  module.exports = require('bindings')('secp256k1')
} catch (err) {
  module.exports = require('./ecurve')
}
fanatid commented 6 years ago

@dcousens looks like you need add browser field to package.json

dcousens commented 6 years ago

Resolved in https://github.com/bitcoinjs/tiny-secp256k1/pull/15