search

bitcoinjs / tiny-secp256k1

A tiny secp256k1 native/JS wrapper
MIT License
90 stars 55 forks source link

Upgrade to WASM #55

Closed fanatid closed 3 years ago

fanatid commented 3 years ago

This is the same as #53 but without node bindings.

Previous work will be available in rust-bindings-api branch: https://github.com/bitcoinjs/tiny-secp256k1/tree/rust-bindings-napi

junderw commented 3 years ago

Verified the diff from the previous PR I reviewed:

https://github.com/bitcoinjs/tiny-secp256k1/compare/364b416568e325510c1899d6661510ba1ccffcd1...88eb5f3cbdf639be18bb16b8280d9e2e3d341a51

Looks good to me.

utACK 88eb5f3cbdf639be18bb16b8280d9e2e3d341a51 (But it doesn't look like the changes will break anything since it's just moving stuff around.

junderw commented 3 years ago

Looks like the tests didn't break!

junderw commented 3 years ago

Next steps:

  1. Update README to explain WASM requirements, how to use it properly, how to build it yourself, toolchain requirements etc.
  2. Once README is updated, add a commit changing package.json and package-lock.json version to 2.0.0 and tag it.