search

bitcoinknots / bitcoin

Bitcoin Knots enhanced Bitcoin node/wallet software
MIT License
200 stars 60 forks source link

p2p: Use absolute FQDN for DNS seeds #40

Closed ghost closed 2 years ago

ghost commented 2 years ago

Fixes issue discussed in https://github.com/bitcoin/bitcoin/issues/23193 by using absolute FQDN for domains used by DNS seeds. It improves security and should not break anything based on my research. Few things about absolute FQDN are shared in https://superuser.com/questions/1467958/why-does-putting-a-dot-after-the-url-remove-login-information

Tested with the steps shared in above issue:

0.21.x-knots branch:

DNS seed x9.dnsseed.bitcoin.dashjr.org. responded with IP 127.0.0.1

PR branch:

DNS seed x9.dnsseed.bitcoin.dashjr.org. responded with IP 159.89.108.149
luke-jr commented 2 years ago

Closing this for now in favour of review occurring on https://github.com/bitcoin/bitcoin/pull/23268