search

bitcoinops / taproot-workshop

Taproot & Schnorr Python Library & Documentation.
MIT License
369 stars 111 forks source link

Fixed capitalization in segwit v1 images. #115

Closed jachiang closed 4 years ago

jachiang commented 4 years ago

Addresses #51 and segwit_version1_1.jpg/svg.

jnewbery commented 4 years ago

Thanks James. Looks good. One suggested change:

"Segwit V1 address" to "Segwit v1 address" (we use lowercase v1 throughout the notebooks).

jachiang commented 4 years ago

Thanks James. Looks good. One suggested change:

"Segwit V1 address" to "Segwit v1 address" (we use lowercase v1 throughout the notebooks).

Fixed. V1 remains capitalized in the image title(s), though?

jachiang commented 4 years ago

Rebased on master (I force pushed twice).

jnewbery commented 4 years ago

V1 remains capitalized in the image title(s), though?

Yes, if the entire title is capitalized.

jnewbery commented 4 years ago

Looks good. Thanks!