Closed jnewbery closed 4 years ago
Agree with above points. Some ideas:
I like pk_hashlock
and pk_delay
. (pk_time
seems fine but isn't relevant to these notebooks).
@jnewbery, just to clarify before I make the changes in the library and chapters.
Our tapscript descriptor tags would be as follows (with hash-locks using OP_HASH160
), right?
pk
pk_delay
pk_hashlock
pk_hashlock_delay
csa
csa_delay
csa_hashlock
csa_hashlock_delay
Our tapscript descriptor tags would be as follows
Yes, that looks good to me.
I will work on this first thing tomorrow, unless you already are @jnewbery?
I will work on this first thing tomorrow, unless you already are @jnewbery?
Thanks! I'm not working on it.
Fixed in #138
A few observations on things that confused workshop particiapnts:
OP_RIPEMD160
is an unusual opcode. I thinkOP_HASH160
is more commonly used (eg lightning HTLCs useOP_HASH160
). We should replaceOP_RIPEMD160
withOP_HASH160
in the notebooks.pkhash
is confusing since it sounds very similar to the 'pubkey hash' in P2PKH. Consider renaming it, perhaps topk_and_hash
orpk_with_hash
?hasholder
andpkhasholder
are slightly confusing since most people seem to parse them as has holder and pk has holder.