bitcoinops / taproot-workshop

Taproot & Schnorr Python Library & Documentation.
MIT License
369 stars 111 forks source link

Changes to taproot descriptors #123

Closed jnewbery closed 4 years ago

jnewbery commented 4 years ago

A few observations on things that confused workshop particiapnts:

jachiang commented 4 years ago

Agree with above points. Some ideas:

jnewbery commented 4 years ago

I like pk_hashlock and pk_delay. (pk_time seems fine but isn't relevant to these notebooks).

jachiang commented 4 years ago

@jnewbery, just to clarify before I make the changes in the library and chapters. Our tapscript descriptor tags would be as follows (with hash-locks using OP_HASH160), right?

jnewbery commented 4 years ago

Our tapscript descriptor tags would be as follows

Yes, that looks good to me.

jachiang commented 4 years ago

I will work on this first thing tomorrow, unless you already are @jnewbery?

jnewbery commented 4 years ago

I will work on this first thing tomorrow, unless you already are @jnewbery?

Thanks! I'm not working on it.

jnewbery commented 4 years ago

Fixed in #138