search

bitcoinops / taproot-workshop

Taproot & Schnorr Python Library & Documentation.
MIT License
375 stars 112 forks source link

[WIP] Add test setup convenience methods #125

Closed jnewbery closed 5 years ago

jnewbery commented 5 years ago

Adds two convenience methods generate_and_send_coins() and create_spending_transaction(). Using those methods removes a lot of the duplicate code in the notebooks that exists simply to setup the tests.

I've added a chapter 2.0 that explains the structure of the 2.x notebooks and introduces the convenience methods. I've also updated chapter 2.1 to use the convenience methods.

If people agree that this is an improvement, I'll update 2.2, 2.3 and 2.4 to use these methods.

Fixes #92

jnewbery commented 5 years ago

Addressed all of @bitschmidty's feedback (thanks!) : https://github.com/bitcoinops/taproot-workshop/compare/f849dddd175d8ee1979baecd4b56d6205ee75786..cd5f378fa2754f716b67834c3a0564ebf9d2baf1

jnewbery commented 5 years ago

Rebased on master

jnewbery commented 5 years ago

I've rebased this on #126, because that makes changes in a lot of places. Please review that first.

jnewbery commented 5 years ago

Rebased on master

jnewbery commented 5 years ago

Pushed a bunch of fixes.

jnewbery commented 5 years ago

Thanks for the review @bitschmidty ! I've fixed all your issues.

jnewbery commented 5 years ago

Addressed @jachiang's feedback (thanks for the review!)

jnewbery commented 5 years ago

Thanks @bitschmidty !