Split-out Jupyter Chapter 0.2 (EC Math Review) from Chapter 1.1 (Schnorr Introduction).

bitcoinops / taproot-workshop

Taproot & Schnorr Python Library & Documentation.

MIT License

375 stars 112 forks source link

Split-out Jupyter Chapter 0.2 (EC Math Review) from Chapter 1.1 (Schnorr Introduction). #13

Closed jachiang closed 5 years ago

jachiang commented 5 years ago

As discussed, the EC math section has been split out from Chapter 1.1 (Schnorr Introduction), and is now considered workshop preparation along with chapter 0.1.

This PR incorporates some of the feedback from Elichai's review of Chapter 1.1.

[x] SECP256K1_ORDER corrections - here
[x] Correction of quadratic residue mod field order - here
[x] Unwieldy ECKey.set(int.to_bytes()) not addressed yet - here

I will wait for @bitschmidty review of chapter 0.2 and 1.1 before tackling unaddressed todo's above.

jnewbery commented 5 years ago

rebased on master

jachiang commented 5 years ago

Updated incorporating feedback from @jnewbery @elichai. Requires this PR branch to run.

TODO:

[x] Update with @bitschmidty feedback.

jnewbery commented 5 years ago

@jnewbery @jachiang Are we having them do this prework exercises at home? Or are the "examples" to be done at home as prework and the "exercises" to be done when reviewing during the workshop?

I think it'd be ideal if the attendees did all the prework at home, and then we go over the solutions on the day.

jnewbery commented 5 years ago

This is looking pretty good. There are a few review comments from me and @bitschmidty .

@bitschmidty - James is busy for the next couple of days. Are you able to implement all of the review comments in your own commit, and then I'll add it to this PR and merge?

jnewbery commented 5 years ago

Merging now. The required changes to the images is tracked in https://github.com/bitcoinops/taproot-workshop/issues/24.