search

bitcoinops / taproot-workshop

Taproot & Schnorr Python Library & Documentation.
MIT License
369 stars 111 forks source link

Add TxInWitness constructor #134

Closed jnewbery closed 4 years ago

jnewbery commented 4 years ago

Originally opened by @jachiang at https://github.com/jnewbery/taproot-workshop/pull/2:

There are a bunch of wrapper classes for the witness, which are just there for serialization, but don't really contribute to the learning process. Suggest to use a txinwitness constructor which consumes an array of witness stack elements.

I've expanded his PR to use the new CTxInWitness constructor for all notebooks.

jnewbery commented 4 years ago

@jachiang - are you able to review this?

jachiang commented 4 years ago

@jachiang - are you able to review this?

Thanks @jnewbery for this update, will do.

jnewbery commented 4 years ago

Thanks @jachiang !