search

bitcoinops / taproot-workshop

Taproot & Schnorr Python Library & Documentation.
MIT License
369 stars 111 forks source link

Add Tapbranch and Taptree constructors #137

Closed jnewbery closed 4 years ago

jnewbery commented 4 years ago

Makes things a bit easier for students by adding constructors for the Tapbranch and Taptree classes.

Also a few other small tidy-ups. Moved tagged_hash() definition out of the notebooks and renamed Node to Tapbranch

jnewbery commented 4 years ago

@jachiang - do you mind reviewing this?

jnewbery commented 4 years ago

Thanks for the review @jachiang . I've addressed all of your comments, and also added a new commit that renamed TaggedHash() to tagged_hash() (by convention, Python uses snake_case for function and variable names, and CamelCase for class names: https://www.python.org/dev/peps/pep-0008/#naming-conventions)

jachiang commented 4 years ago

tACK 16f84cf049d7f92bff03f08db5ef87aab6cb6a6

Reviewed & Tested. Thanks @jnewbery!

jachiang commented 4 years ago

by convention, Python uses snake_case for function and variable names, and CamelCase for class names

Thanks, I will apply this convention in the future.