search

bitcoinops / taproot-workshop

Taproot & Schnorr Python Library & Documentation.
MIT License
369 stars 111 forks source link

typo: private key, not public key #144

Closed MaxHillebrand closed 4 years ago

MaxHillebrand commented 4 years ago

the deterministic nonce is generated by hashing the private [not public] key and the hash of the message.

MaxHillebrand commented 4 years ago

Oh, I see this is a duplicate fix from #104 - the fix got reverted in #117.

jachiang commented 4 years ago

ACK. Thank you. Deterministic nonce is necessarily a private scalar value.

jnewbery commented 4 years ago

Thanks @MaxHillebrand !

I think this would actually be clearer if it said "use sha256(bytes) on the private key and message" (since the preimage should be (bytes(d) || m))

Are you happy to update both the chapter notebook and solution notebook?