consistent naming in python code

bitcoinops / taproot-workshop

Taproot & Schnorr Python Library & Documentation.

MIT License

369 stars 111 forks source link

Closed OttoAllmendinger closed 4 months ago

OttoAllmendinger commented 4 years ago

there are a few inconsistencies that make it a bit harder than necessary to write the code

order of verb and noun should be consistent: ECPubKey.get_bytes() and ECPubKey.tweak_add()
variable naming style should be consistent: pubkey1, taproot_pubkey_1, TapLeafA (snake_case is the python convention)

jnewbery commented 4 years ago

I definitely agree. Having inconsistent naming conventions is confusing and distracting. Thanks for pointing these out.

bitschmidty commented 4 months ago

Concept ack, but doesnt look like anyone has taken this effort up yet, so closing.