Update workshop to use 0.21

ellemouton commented 3 years ago

This PR updates the workshop to use the 0.21 binary directly.

It also updates the notebooks so that they are aligned with the changes that have been made to the BIPs including:

Change from 33 byte encoding of public key to 32 byte encoding
Change from assuming that a nonce point has a y-coordinate that is quadratic residue to a y-coordinate that is even
Change in the elements of the control block

ellemouton commented 3 years ago

Thanks for the review @glozow 😄 I will update accordingly later this week 👍

ellemouton commented 3 years ago

Updated since your review @glozow :) ready for re-review. (For some reason the 'request re-review' button does not seem to be working)

ellemouton commented 3 years ago

Thanks @glozow 🚀

jnewbery commented 3 years ago

I've pushed a bunch of very minor edits:

making sure that the exercises are fully sync'ed between the worksheets and solutions sheets
updating to use bech32m for segwit v1
standardizing on the optech style of BIP340 (instead of bip-0340)

This is great work. Thanks so much for implementing it @ellemouton and for review @glozow. Apologies that it took me so long to get round to merging.

@ellemouton - there's just one minor requested change here: https://github.com/bitcoinops/taproot-workshop/pull/168#discussion_r673864291. Totally non-blocking, and not a problem at all if you don't have time to make the suggested change.

bitcoinops / taproot-workshop