Update for bech32m, note tr() descriptors, remove old BIP342 limitation, and fix some typos

bitcoinops / taproot-workshop

Taproot & Schnorr Python Library & Documentation.

MIT License

369 stars 111 forks source link

Update for bech32m, note tr() descriptors, remove old BIP342 limitation, and fix some typos #169

Closed harding closed 3 years ago

harding commented 3 years ago

Should be easiest to review by going through commits individually.

(This set of workbooks was great! I'm sorry I didn't go through them earlier.)

jnewbery commented 3 years ago

Thanks @harding. All the text changes in the workbooks look great.

Are the changes to address.py or segwit_addr.py necessary? The existing code in this repo more closely matches the code in the Bitcoin Core repo.

harding commented 3 years ago

Are the changes to address.py or segwit_addr.py necessary? The existing code in this repo more closely matches the code in the Bitcoin Core repo.

Oh, hmm. Maybe not. I guess I should've looked closer before just using the latest code from the reference implementation. I'll drop that part of the change.