Colab branch is outdated

bitcoinops / taproot-workshop

Taproot & Schnorr Python Library & Documentation.

MIT License

375 stars 112 forks source link

Colab branch is outdated #172

Closed mmilata closed 3 years ago

mmilata commented 3 years ago

E.g. in 1.1(master, Colab) the Colab branch has outdated (pre-BIP maybe?) definition of Schnorr signing, but uses test_framework from master. Due to this mismatch the exercises are unsolvable.

Is there anything else than rebasing Colab on top of master needed?

mmilata commented 3 years ago

Found some more examples that don't currently work in Colab. Could https://github.com/bitcoinops/bitcoin/releases/download/Taproot_V0.1.4/colab-binary.tar.xz be outdated?

2.0-taproot-introduction 2.0.2 fails on assert balance > 1
2.1-segwit-version-1 2.12 fails with JSONRPCException: Invalid Bitcoin address: bcrt1pqx46s2tuvp2m7ylr036yjsd4nevs4atys2nwm6408cpfgutyyanqytcn5m (-5)

cc @0xB10C, any ideas?

0xB10C commented 3 years ago

Thanks for pining me, happy to help you update the colab notebooks.

Could https://github.com/bitcoinops/bitcoin/releases/download/Taproot_V0.1.4/colab-binary.tar.xz be outdated?

IIRC the colab-binary.tar.xz was used as taproot was far from being merged into master when creating the Colab version of these notebooks. As the workshop is compatible with v0.21 since https://github.com/bitcoinops/taproot-workshop/pull/168, I think we should be able to use the v0.21 release build (or even 22.0) now.

jnewbery commented 3 years ago

Fixed in #173