search

bitcoinops / taproot-workshop

Taproot & Schnorr Python Library & Documentation.
MIT License
375 stars 112 forks source link

updates for bitcoin core 23.0 compatibility #177

Closed mruddy closed 2 years ago

mruddy commented 2 years ago

here are a couple of updates to allow these notebooks to work with bitcoin core 23.0 (and the current master branch if building locally).

first, descriptor wallets are now the default wallet type. so, we need to set descriptors to false during wallet creation in order to be able to import private keys.

second, the soft fork status info has been moved from getblockchaininfo to getdeploymentinfo.

mruddy commented 2 years ago

i'm going to close this becuase it doesn't seem like there's anything being pulled in at this time. i suppose this being in the history could still help someone if they try to go through the workshop materials.

jnewbery commented 2 years ago

@bitschmidty if this project is no longer accepting PRs, perhaps it's best to mark it as archived and update the readme?

michaelfolkson commented 2 years ago

It would be nice to keep this workshop compatible with latest versions of Bitcoin Core right? Still a great educational resource post activation? So just a (human) resource issue of reviewing PRs to keep it compatible.

bitschmidty commented 2 years ago

@mruddy thanks for the PR and sorry for the delay in getting back to you here. If youd like to reopen, I can review. (and would address #178 as well!)