search

bitcoinops / taproot-workshop

Taproot & Schnorr Python Library & Documentation.
MIT License
375 stars 112 forks source link

added descriptors false flag #178

Closed cwarny closed 2 years ago

cwarny commented 2 years ago

The notebook depends on using legacy wallets instead of descriptor wallets. If using the latter, the BitcoinTestFramework class fails on line 349:

n.importprivkey(privkey=n.get_deterministic_priv_key().key, label='coinbase')

Since Bitcoin Core v23, descriptor wallets became the default, and therefore the notebook fails, unless you add a descriptors=False argument to the createwallet call. I suggest you either merge this PR or mention in the readme that the notebook requires v21 <= Bitcoin Core version < v23.

michaelfolkson commented 2 years ago

177 highlighted this too

bitschmidty commented 2 years ago

@cwarny thanks for the PR, just merged https://github.com/bitcoinops/taproot-workshop/pull/177 which covers this change as well