search

bitcoinops / taproot-workshop

Taproot & Schnorr Python Library & Documentation.
MIT License
375 stars 112 forks source link

Field Size in Quadratic Residue instead of Group Order, and some nits #57

Closed elichai closed 5 years ago

elichai commented 5 years ago

Nits that I saw while reading the notebooks again

This is mostly changing to using the field size for the quadratic residue stuff, and also a bit of wording.

And one actual fix that uncompressed keys were needed.

Trying to maintain consistency between SECP256K1_ORDER(aka group order) and SECP256K1_FIELD_SIZE (aka field size)

jnewbery commented 5 years ago

Looks good. Thanks!