search

bitcoinops / taproot-workshop

Taproot & Schnorr Python Library & Documentation.
MIT License
375 stars 112 forks source link

Workshop markups #82

Closed jnewbery closed 5 years ago

jnewbery commented 5 years ago

A bunch of changes to the notebooks and test framework.

I can separate the test framework commits into their own PR if that helps.

jnewbery commented 5 years ago

@elichai - mind reviewing?

jnewbery commented 5 years ago

Rebased on master.

I've also split the framework enhancements into their own PR at #83 . @elichai - can you review that first?

jnewbery commented 5 years ago

Rebased on master and applied Elichai's review comments.

jnewbery commented 5 years ago

Changed the manual nonce assignment per elichai's suggestion.

There was also a bug in the ECPubKey.negate() method, which I fixed.

jnewbery commented 5 years ago

Rebased on master and applied a few minor fixes

jnewbery commented 5 years ago

This is ready for review

jnewbery commented 5 years ago

I'm going to go ahead and merge this now