search

bitcoinsearch / bitcoinsearch-app

Search the depths of bitcoin’s technical ecosystem
https://bitcoinsearch.xyz
Apache License 2.0
19 stars 13 forks source link

Result UI and Functionality bugs (Search component) #100

Closed 0tuedon closed 5 months ago

vercel[bot] commented 6 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bitcoinsearch-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 9, 2024 8:33pm
Extheoisah commented 6 months ago

After running the 1st query, when I search for another keyword e.g. htlc, it doesn't go through

0tuedon commented 6 months ago

After running the 1st query, when I search for another keyword e.g. htlc, it doesn't go through

just noticed it, my work was mainly on the result Ui, but will check out this issue

0tuedon commented 6 months ago

@Extheoisah Updated

Extheoisah commented 6 months ago

Its coming together. A few nits:

  1. The spacing between results doesn't match the design. The search results are too close.
  2. The spacing between the pagination component and holocat is small in comparison with the design. see the design screenshot. image
Extheoisah commented 6 months ago

found an edge case when you have many authors in a search result image

0tuedon commented 5 months ago

https://github.com/bitcoinsearch/bitcoinsearch-app/assets/90271995/8e3f1d69-4bc4-4f39-910d-3e7aed8912c7

Extheoisah commented 5 months ago

Some issues I noticed with the latest deployment:

  1. the author list sometimes gets cut-off by styling. Only after clicking does it render properly image

  2. we get non-authors in the author list sometimes. image image

0tuedon commented 5 months ago

Hey @Extheoisah Thanks for this, although I am having issues with the Paginations not working with big numbers

0tuedon commented 5 months ago

Updated @Extheoisah except the Pagination and authors

Extheoisah commented 5 months ago

The issue with the pagination is that the forward and backward button (highlighted in red box in the image below) don't take you to the first and last of the result respectively image

The authors issue can be fixed in another PR since it is not scoped to this task

0tuedon commented 5 months ago

The issue with the pagination is that the forward and backward button (highlighted in red box in the image below) don't take you to the first and last of the result respectively image

The authors issue can be fixed in another PR since it is not scoped to this task

oh oh , no it's meant to double your speed for example go about 5 steps faster there should always be a 1 when you are far off in the pagination

Extheoisah commented 5 months ago

The authors issue can be fixed in another PR since it is not scoped to this task

Isn't it supposed to go to the first page result? why 5 steps The user doesn't know that. We should make it go to the 1st result for the forward arrow and for the back arrow, it should go to the last result. If users want to go 5 steps, they can always click on the pagination numbers in between

0tuedon commented 5 months ago

The authors issue can be fixed in another PR since it is not scoped to this task

Isn't it supposed to go to the first page result? why 5 steps The user doesn't know that. We should make it go to the 1st result for the forward arrow and for the back arrow, it should go to the last result. If users want to go 5 steps, they can always click on the pagination numbers in between

Sure, made an update on that.