search

bitcoinsearch / bitcoinsearch-app

Search the depths of bitcoin’s technical ecosystem
https://bitcoinsearch.xyz
Apache License 2.0
15 stars 13 forks source link

fix: UI cleanups #105

Closed Emmanuel-Develops closed 4 weeks ago

Emmanuel-Develops commented 3 months ago

closes #107

closes #112 here f087cb2abcf1e1d403f7bf5151dbf91ccb9b38a3

closes #103 #106

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bitcoinsearch-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2024 9:48pm
BalogunofAfrica commented 2 months ago

@Emmanuel-Develops I think the other commits are out of scope for this PR.

Emmanuel-Develops commented 2 months ago

@Emmanuel-Develops I think the other commits are out of scope for this PR.

yeah, this is meant to be the cleanup PR. I'll change the description

Extheoisah commented 2 months ago

Here are some styling issues I noticed:

  1. no padding at the top of the search results
  2. staging deployment has no scroll bars but this preview deployment has scrollbars
  3. Aspect ratio is still large image
kouloumos commented 2 months ago

Here are some issues that I noticed:

Extheoisah commented 2 months ago

Here are some issues that I noticed:

  • Screencastfrom2024-04-1511-20-44-ezgif com-video-to-gif-converter

      [

      ![Screencastfrom2024-04-1511-20-44-ezgif com-video-to-gif-converter](https://private-user-images.githubusercontent.com/18506343/322407131-0ed3fb4b-7962-44a5-9148-e1224bae941d.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTMyMjgzOTUsIm5iZiI6MTcxMzIyODA5NSwicGF0aCI6Ii8xODUwNjM0My8zMjI0MDcxMzEtMGVkM2ZiNGItNzk2Mi00NGE1LTkxNDgtZTEyMjRiYWU5NDFkLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA0MTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNDE2VDAwNDEzNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTkxNjAxZWUyN2Q3YmYwZGNmMTFkNDdhZjAzN2ExZTg5NjdmZmQwNTA0ZmJiMjk5YzZiMTA2OTc5OWFlMDdjNGYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.c_zsOFf4YxHhI1z5ixJfOyBR34JRmp4pd_bWQrlXMA0)
    ](https://private-user-images.githubusercontent.com/18506343/322407131-0ed3fb4b-7962-44a5-9148-e1224bae941d.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTMyMjgzOTUsIm5iZiI6MTcxMzIyODA5NSwicGF0aCI6Ii8xODUwNjM0My8zMjI0MDcxMzEtMGVkM2ZiNGItNzk2Mi00NGE1LTkxNDgtZTEyMjRiYWU5NDFkLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA0MTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNDE2VDAwNDEzNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTkxNjAxZWUyN2Q3YmYwZGNmMTFkNDdhZjAzN2ExZTg5NjdmZmQwNTA0ZmJiMjk5YzZiMTA2OTc5OWFlMDdjNGYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.c_zsOFf4YxHhI1z5ixJfOyBR34JRmp4pd_bWQrlXMA0)

    [

    ](https://private-user-images.githubusercontent.com/18506343/322407131-0ed3fb4b-7962-44a5-9148-e1224bae941d.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTMyMjgzOTUsIm5iZiI6MTcxMzIyODA5NSwicGF0aCI6Ii8xODUwNjM0My8zMjI0MDcxMzEtMGVkM2ZiNGItNzk2Mi00NGE1LTkxNDgtZTEyMjRiYWU5NDFkLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA0MTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNDE2VDAwNDEzNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTkxNjAxZWUyN2Q3YmYwZGNmMTFkNDdhZjAzN2ExZTg5NjdmZmQwNTA0ZmJiMjk5YzZiMTA2OTc5OWFlMDdjNGYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.c_zsOFf4YxHhI1z5ixJfOyBR34JRmp4pd_bWQrlXMA0)
    • The homepage is still visible after the search results
    • The footer is rendered twice

  • image

    • The are 2 entries for "Mastering Lightning". When I click on them, the first filters for "Mastering Bitcoin"

I'm curious as to how you got the first two issues with the homepage and footer being render twice. I haven't been able to replicate

kouloumos commented 2 months ago

I'm curious as to how you got the first two issues with the homepage and footer being render twice. I haven't been able to replicate

Not sure how that happened, I can't reproduce them anymore :confused:

Emmanuel-Develops commented 2 months ago

Looks good, I just have an issue where if I try to scroll within authors it opens the link, check the video below

Screen.Recording.2024-04-18.at.09.19.06.mov

resolved

Looks good, I just have an issue where if I try to scroll within authors it opens the link, check the video below

Screen.Recording.2024-04-18.at.09.19.06.mov

This has been addressed in commit https://github.com/bitcoinsearch/bitcoinsearch-app/pull/105/commits/35fe3b154e2055638a6f520301aa6080d23324de. Kindly test again

Extheoisah commented 2 months ago

Some results have dates while others do not. Any reason for the disparity? search query: Adaptor signatures

Emmanuel-Develops commented 2 months ago

Some results have dates while others do not. Any reason for the disparity? search query: Adaptor signatures

Some results are missing the createdAt field. The only other date field is the indexedAt field which doesn't carry the same context so I'm leaving it blank for now

0tuedon commented 1 month ago
Screenshot 2024-05-13 at 17 49 00

Good stuff, one final review could we change the cursor to a pointer on the arrows

Emmanuel-Develops commented 1 month ago

Good stuff, one final review could we change the cursor to a pointer on the arrows

here 3923445