staging feedback

[adamjonas]

based on https://bitcoinsearch-43t9q2gbz-btc-knowledge-base.vercel.app/

This leaks too far down (below the fold, shorten it)

Github item isn't visible

Some spans are links and some aren't. Why is the date a link but the icon or source isn't? Remove the https:// from all urls. It makes them unnecessarily long.

Are the app descriptions the same font as the rest of the site? Why is the dev project in grey and the others in black?

Sources leak onto a second row

Here they are all two rows and but don't fill up the width of the div

Gnusha should be bitcoin-dev mailing list

[adamjonas]

If I click on the search bar in mobile I get all the suggestions plus my keyboard pops up. This is hard for me to navigate. I have doubts whether the suggestions, as currently implemented, will work on mobile.

The Bitcoin dev mailing list who isn't be labeled as the Linuxfoundation

This url in the search bar is really ugly and has no semantic meaning

Can't scroll down the app list on mobile

The filter button is disabled once I open the filter menu. I have to use a different button and it's not clear on mobile what that icon represents.

Is this how we want to footer to look in dark mode mobile? At the very least the GitHub icon doesn't look consistent with the other items.

The font size on mobile feels small

[Emmanuel-Develops]

Some spans are links and some aren't. Why is the date a link but the icon or source isn't?

The card itself (the container) is clickable and takes the user to the link. By icon and source are you referring to the source domain (e.g https://bitcoinops.org/en/)?

[Emmanuel-Develops]

Are the app descriptions the same font as the rest of the site?

There are 2 fonts used globally in the site,

• Geist
• Mona Sans The font used in the app descriptions is 'Mona Sans', which is the same font used in filters.

  Why is the dev project in grey and the others in black?

design guide, not sure there's a specific reason for that. Maybe showcase parent?, while the rest apps are under that parent.

[Emmanuel-Develops]

Github item isn't visible

fixed in latest commit

[aassoiants]

Made into task list

Desktop

• [x] This leaks too far down (below the fold, shorten it)
• [x] Github item isn't visible
• [x] Some spans are links and some aren't. Why is the date a link but the icon or source isn't? Remove the https:// from all urls. It makes them unnecessarily long.
• [x] Are the app descriptions the same font as the rest of the site? Why is the dev project in grey and the others in black?
• [x] Sources leak onto a second row
• [ ] Here they are all two rows and but don't fill up the width of the div
• [x] Gnusha should be bitcoin-dev mailing list

Mobile

• [x] If I click on the search bar in mobile I get all the suggestions plus my keyboard pops up. This is hard for me to navigate. I have doubts whether the suggestions, as currently implemented, will work on mobile.
• [x] The Bitcoin dev mailing list who isn't be labeled as the Linuxfoundation
• [x] This url in the search bar is really ugly and has no semantic meaning
• [ ] Can't scroll down the app list on mobile
• [x] The filter button is disabled once I open the filter menu. I have to use a different button and it's not clear on mobile what that icon represents.
• [x] Is this how we want to footer to look in dark mode mobile? At the very least the GitHub icon doesn't look consistent with the other items.
• [x] The font size on mobile feels small

[Emmanuel-Develops]

Gnusha should be bitcoin-dev mailing list

We'll need to discuss how we scrape it then or merge them. For now bitcoin-dev via Gnusha can work, or bitcoin-dev (gnusha) or what do you think?

Because they are seen as separate entities in the index and a duplicate bitcoin-dev domain filter may be confusing

[aassoiants]

@Emmanuel-Develops i like the bitcoin-dev (gnusha) solution

But curious what other options exist. This isn't a blocker for launching.

[adamjonas]

These pills are still not aligned:

---

The author pill isn't consistent when there isn't a date attached to a record

---

The formatting here isn't going to work. Also just call it all the bitcoin-dev mailing list. There is no reason to differentiate.

---

This passed validation:

---

after I submit a source the url input clears and there is a notable delay before the submitted successfully modal comes up. I didn't it twice and each time it felt like I did something wrong.

---

Two things here. 1) there is a white boarder on the rounded corners that doesn't look right. 2) That big green button looks like a button. But it's not a button. It should be a button that closes the modal.

---

This first impression on mobile after clicking on the search bar is rough:

---

Is this the number of filters I have? The alignment makes it looks like a mistake. Also, this is only visible in light mode and totally invisible in dark mode.

[Emmanuel-Develops]

cc: @adamjonas

These pills are still not aligned:

I need clarity on this? is it the wrap to another row?

The author pill isn't consistent when there isn't a date attached to a record

good observation, I'll fix that.` fixed

The formatting here isn't going to work. Also just call it all the bitcoin-dev mailing list. There is no reason to differentiate.

we use the same naming for filtering domains. There's a json where we mapped the URLs and their respective display names.

using Bitcoin Dev mailing list will be confusing as shown in the second image above.

A hacky solution could be conditionally look for "gnusha" URLs in the results and display as Bitcoin Dev mailing list while leaving filter as Bitcoin Dev (Gnusha) (not a fan!)

[Emmanuel-Develops]

This passed validation:

fixed (switched from native HTML URL and email validation to regex)

after I submit a source the url input clears and there is a notable delay before the submitted successfully modal comes up. I didn't it twice and each time it felt like I did something wrong.

fixed (added loading visual cue, prevented double submit)

Two things here. 1) there is a white boarder on the rounded corners that doesn't look right. 2) That big green button looks like a button. But it's not a button. It should be a button that closes the modal.

fixed

Is this the number of filters I have? The alignment makes it looks like a mistake. Also, this is only visible in light mode and totally invisible in dark mode.

fixed

[adamjonas]

is it the wrap to another row?

Yes. Why do we need so many that some leak onto the next row?

Re

How are you expecting a seacher to know the difference? Combine them and have the filters search both.

[Emmanuel-Develops]

Yes. Why do we need so many that some leak onto the next row?

I guess less leakage is good for mobile (I don't have much of a preference on this). I've set it to only one row so wider screens show more pills.

[Emmanuel-Develops]

How are you expecting a seacher to know the difference? Combine them and have the filters search both.

Combining on the FE will be a very hacky approach (based on how the logic is setup). Its better to combine in the index itself. Is this critical for launch?

[adamjonas]

They can't be combined on elastic search. They come from different sources.