search

bitcoinsearch / bitcoinsearch-app

Search the depths of bitcoin’s technical ecosystem
https://bitcoinsearch.xyz
Apache License 2.0
19 stars 13 forks source link

Product Feedback v2 #118

Open aassoiants opened 4 months ago

aassoiants commented 4 months ago

Great work team!

I did test using Windows Brave. And mobile Brave.

Mobile Page

Search Page

Emmanuel-Develops commented 4 months ago

When i click out of a selected source when AND when there is nothing searched (t.i., only after choosing something from the search bar drop down), it returns me to the homepage at the same scroll that i was on in the search page. Not anchored to the above the scroll as it should be. (Doesn't happen on mobile)

I made selecting filters on desktop stay in place because the filters and results are side by side, whereas for mobile selecting a filter moves to results page and then it wouldn't be a good ux to keep user mid scroll.

Looking at it now all filters should scroll to the top because its new data and you want users aware these are new results.

Oh and for what you experienced, this applies to homepage as well. As when there's no query params (search, filter or sort) we just swap the results page for homepage.

FIXED in 5d423d5

Extheoisah commented 4 months ago

The screen kind of moves around when toggling between the "suggest a source" feature and existing it (look at the header). (Only desktop).

I think its because when the modal comes into focus and the background is out of focus, the scrollbar is hidden which leaves more room for the header to expand. But on modal close, the scrollbar is visible and takes the usual space. I don't think this issue should be a blocker.

Emmanuel-Develops commented 4 months ago

Let's please remove or blur out the location in the left lightning image

paper is working on this

Emmanuel-Develops commented 4 months ago

Clicking the logo button to get the homescreen took a second longer than it should have. See if you can replicate.

@aassoiants you're nitpicking! 👀 I wrote an optimization for this some days back so I'm surprised there's an issue at all. I can't replicate it, can you record a video please

The screen kind of moves around when toggling between the "suggest a source" feature and existing it (look at the header). (Only desktop).

As Theo said, the modal causes the scrollbar to be hidden, hence extra space and the header expands to fill that space. It doesn't show up on mac tho because of native mac scrollbar behavior.

aassoiants commented 4 months ago

@aassoiants you're nitpicking! 👀 I wrote an optimization for this some days back so I'm surprised there's an issue at all. I can't replicate it, can you record a video please

Haha eagle eyes! Don't worry if can't repli.

As Theo said, the modal causes the scrollbar to be hidden, hence extra space and the header expands to fill that space. It doesn't show up on mac tho because of native mac scrollbar behavior.

If this takes more than a day to solve, then put to post-launch please

Emmanuel-Develops commented 4 months ago

If this takes more than a day to solve, then put to post-launch please

I've been on chat for a while, this issue is a bit niche and hard to test as it only shows up in Windows. Let's move it post-launch.

adamjonas commented 4 months ago

Some questions...

On https://bitcoinsearch-app-git-fix-filterdomai-bc4eff-btc-knowledge-base.vercel.app/?filter_domain=https%3A%2F%2Flists.linuxfoundation.org%2Fpipermail%2Fbitcoin-dev%2F&filter_authors=Ava+Chow

The rolled up replies are only Ava Chow. Should we be showing all replies to the post she authored or is this expected?

Can't read the BDP on dark mode: image

Can't see this image on dark mode image

The entire box describing chat should be linked rather than that tiny text. Also should the pagination be full width or centered? image

Can we make this pull down longer so I don't have to scroll? image

aassoiants commented 4 months ago

Thanks @adamjonas!

Questions

Do Now

Do Later

aassoiants commented 4 months ago

A few obsies on Brave. Desktop. Windows.

Emmanuel-Develops commented 3 months ago

No serp card description/ copy for (only?) bitcoinops topics.

Its an issue with the scraping, I think andreas is looking into it cc: @kouloumos

Unsure what the difference is between "Bitcoin Dev Mailing List" vs "Bitcoin Dev Mailing List Archive" vs "Bitcoin Dev Mailing List Active"

"Bitcoin Dev Mailing List" -> mailing-list.bitcoindevs.xyz (our google groups list) "Bitcoin Dev Mailing List Archive" -> list linux foundation "Bitcoin Dev Mailing List Active" -> gnusha google groups

@urvishp80 replaced the domain gnusha domain with ours on the index, seems a recent scraper reintroduced the gnusha domain back, given that the earliest appearance is 11th May.

Screenshot 2024-06-05 at 4 38 53 PM

I don't think the drop-down options should exist when a user's on the Search UI/ Search page.

I'm indifferent about it, but you make a solid case.

edit: The PR https://github.com/bitcoinsearch/scraper/pull/64/ fixes the 2 scraping issues

kouloumos commented 3 months ago

Unsure what the difference is between "Bitcoin Dev Mailing List" vs "Bitcoin Dev Mailing List Archive" vs "Bitcoin Dev Mailing List Active"

@Emmanuel-Develops can you explain (or point to the relevant code) how we come up with

Bitcoin Dev Mailing List" vs "Bitcoin Dev Mailing List Archive" vs "Bitcoin Dev Mailing List Active"

is this something that comes directly from elasticsearch?

Everything should be called "Bitcoin Dev Mailing List" on the frontend. If this needs to be fixed in elasticsearch-index level then we should call them all the same at that level. The urls show the actual source (archive, active, _) but that's not something that concerns the user when searching on Bitcoin Search. @urvishp80 has more context on that.

Emmanuel-Develops commented 3 months ago

@Emmanuel-Develops can you explain (or point to the relevant code) how we come up with

@kouloumos This was done during the transition from gnusha to our google groups domain (mailing-list.bitcoindevs.xyz). Its basically a mapping on the FE Here: https://github.com/bitcoinsearch/bitcoinsearch-app/blob/fe14f45612b1af7a1c1c00c178659ff6eebb44e6/src/config/mapping.json#L5 https://github.com/bitcoinsearch/bitcoinsearch-app/blob/fe14f45612b1af7a1c1c00c178659ff6eebb44e6/src/config/mapping.json#L63-L64

is this something that comes directly from elasticsearch?

No it is not, it comes from the mapping.json shown above.

They can't all be "Bitcoin Dev Mailing List" because the ES index returns both the archive lists.linux... and active mailing-list.bitcoindevs.xyz... from queries. Users will see duplicated "Bitcoin Dev Mailing List" when sorting by domain and won't be able to tell archive and active apart.

The index is meant to map gnusha.. to mailing-list.bitcoindevs.xyz.. and @urvishp80 is doing that in the current open PR on scraper, here: https://github.com/bitcoinsearch/scraper/blob/41d616f264c9acf09e226aeea03fd9bffd9fcde2/mailing-list/main.py#L17-L18 and he replaces the domain here https://github.com/bitcoinsearch/scraper/blob/41d616f264c9acf09e226aeea03fd9bffd9fcde2/mailing-list/main.py#L192

urvishp80 commented 3 months ago

Based on chat with @adamjonas, I updated the scraper (related to bitcoin-dev) code as follows:

  1. changed the value of domain field for all the docs:
    • from https://gnusha.org/pi/bitcoindev/ to https://mailing-list.bitcoindevs.xyz/bitcoindev/
    • keep https://lists.linuxfoundation.org/pipermail/bitcoin-dev/ and https://lists.linuxfoundation.org/pipermail/lightning-dev/ as it is

However, as the PR has not been merged yet. Here are the counts for the docs in the Elasticsearch Index for the given domain:

Here is the message from @Emmanuel-Develops regarding the Frontend.