search

bitcointranscripts / transcription-review-front-end

https://review.btctranscripts.com
3 stars 7 forks source link

Guidelines modal #259

Closed 0tuedon closed 8 months ago

0tuedon commented 8 months ago

How to test for first timers

  1. Make sure you don't have any reviews either pending, inactive or active, if you have time you could negate the code in queuetable.tsx line 194 if (multipleStatusData.length > 0) {

How to test for old timers

  1. There is an orange review Guidlines button at the top of the editor, click that and you have your modal

we could change the design going forward.

TESTED.

vercel[bot] commented 8 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
transcription-review-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 1, 2024 1:02pm
0tuedon commented 8 months ago

@0tuedon modal looks good! I pushed some UI changes alongside a CTA for our discord server, please check them out and once you approve them we can merge this.

Also with ef0196a , I renamed the component to a more appropriate name as you moved it to the /modals directory.

Screenshot 2024-02-01 at 14 19 16

Looks good My only concern is, why on the right?

kouloumos commented 8 months ago

My only concern is, why on the right?

Just a design decision. I believe that aligning the call to action to the right helps create a visual separation and draws attention to it. It signals that it's a distinct and important piece of information.

kouloumos commented 8 months ago

@0tuedon I think that based on what we discussed about atomic commits, we should squash the last 5 commits into 32243a38c9a670d8a64d8ea631cf823a0b82a01f before merging.