bitcointranscripts / transcription-review-front-end

https://review.btctranscripts.com
3 stars 7 forks source link

Admin page (Table Status, Search by username) #287

Closed 0tuedon closed 5 months ago

0tuedon commented 5 months ago

PR Checklist

How to Test To test this pr make sure you are an admin and navigate to reviews/all or use the sidebar navigation.

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
transcription-review-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2024 5:20pm
Extheoisah commented 5 months ago

When I'm on the review page, the Review text doesn't have a background color to show that I'm on that route like we have for the Transactions page. We should use the same background color when the review page is in focus image

0tuedon commented 5 months ago

When I'm on the review page, the Review text doesn't have a background color to show that I'm on that route like we have for the Transactions page. We should use the same background color when the review page is in focus ![image]

This updated commit should fix for both transactions and reviews when there are filters

Extheoisah commented 5 months ago

Can you add some padding in between "Transactions" and "Reviews"? No need to create a new commit. You can just amend the recent commit to include this change

Screenshot 2024-05-07 at 16 56 12
0tuedon commented 5 months ago

Reset Review: Leverage the existing /api/reviews/{id}/reset API endpoint to allow admins to reset an active review in the same way that admins can archive a transcript in the /transcripts page. Additional Table Fields Based on Status For Active reviews: Include the remaining time before the review expires. For Pending reviews: Include a link to the pull request URL (pr_url) and the submission date. For Merged reviews: Display the fields available in Pending reviews, plus the date the review was merged and a link to the final transcript. Note: For dates displayed in the table, including the exact time is essential. To maintain a clean layout, we can show only the date initially, with the full date and time details appearing in a tooltip upon hovering over the date.

When merging pls note that there will be an additional PR for these additional issues.

Extheoisah commented 5 months ago

merging now. @0tuedon Lets address the other issues in another pr

kouloumos commented 5 months ago

Great work @0tuedon! A couple of issues while reviewing this post-merged:

  1. The status column is not useful as it is, "queued" or "not queued" is not useful information. The status should be displayed as one of the actual status with which you can filter (active, merged, etc.). This way when you search for a specific user/transcript, you can see the actual status of the previous claims.
  2. Filtering should reset the url. As it is, it creates issues when for example you go on the second page of the table and then apply a filtering.
  3. Updated At is not useful as a column. Let's remove it on the next update.
  4. The Transactions table has a count of Results on the top right corner, let's also add this here
  5. "Expired" filter also displays merged reviews.