search

bitcointranscripts / transcription-review-front-end

https://review.btctranscripts.com
3 stars 7 forks source link

Evaluator role access #296

Closed 0tuedon closed 3 months ago

0tuedon commented 3 months ago

This PR closes #291

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
transcription-review-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2024 11:54am
0tuedon commented 3 months ago

What do you think?

Thanks for this, I would do a custom hook for the implementation as suggested.

0tuedon commented 3 months ago

I made commits to address the mentioned issues on this review

IgboPharaoh commented 3 months ago

I made commits to address the mentioned issues on this review

Nice work overall, I left a few comments as regards some nits and observations. I tested as a reviewer and cannot see the admin nav or other things I've been restricted to. Is there a way I can switch my role to that of an evaluator and test ?

0tuedon commented 3 months ago

I made commits to address the mentioned issues on this review

Nice work overall, I left a few comments as regards some nits and observations. I tested as a reviewer and cannot see the admin nav or other things I've been restricted to. Is there a way I can switch my role to that of an evaluator and test ?

You could test by moving all evaluators permissions to your current role.

or I could change your role on staging.

Are you using staging to test?

IgboPharaoh commented 3 months ago

I made commits to address the mentioned issues on this review

Nice work overall, I left a few comments as regards some nits and observations. I tested as a reviewer and cannot see the admin nav or other things I've been restricted to. Is there a way I can switch my role to that of an evaluator and test ?

You could test by moving all evaluators permissions to your current role.

or I could change your role on staging.

Are you using staging to test?

I am using the staging link to test

0tuedon commented 3 months ago

I am using the staging link to test

which would you prefer?, changed to a evaluator. if you want to test as an admin let me know

IgboPharaoh commented 3 months ago

I am using the staging link to test

which would you prefer?, changed to a evaluator. if you want to test as an admin let me know

Evaluator please

0tuedon commented 3 months ago

Updated

kouloumos commented 3 months ago

LGTM!