search

bitcoinvsalts / node-binance-trader

💰 Cryptocurrency Trading Strategy & Portfolio Management Development Framework for Binance. 🤖
https://bitcoinvsalts.com
MIT License
1.17k stars 380 forks source link

removing duplicate code, also cleaning up some stuff.. #108

Closed xcxooxl closed 3 years ago

xcxooxl commented 3 years ago

this might be on going process.

dargmuesli commented 3 years ago

Hey there, thanks for your contribution! Two ideas:

  1. if this is still in progress, you can set this PR to "draft" status
  2. as noted in https://github.com/jsappme/node-binance-trader/issues/107, I'm currently rewriting the code in typescript, cleaning the overall structure too. Let's not duplicate the work, but create an issue describing the wanted changes so we can communicate about those intentions.
xcxooxl commented 3 years ago

Hey there, thanks for your contribution! Two ideas:

  1. if this is still in progress, you can set this PR to "draft" status
  2. as noted in #107, I'm currently rewriting the code in typescript, cleaning the overall structure too. Let's not duplicate the work, but create an issue describing the wanted changes so we can communicate about those intentions.

is there a branch for that? maybe I could help

dargmuesli commented 3 years ago

Not yet. I'll create one when it's ready for review. I'd be happy if you could take a look at it then! :)