search

bitcoinvsalts / node-binance-trader

💰 Cryptocurrency Trading Strategy & Portfolio Management Development Framework for Binance. 🤖
https://bitcoinvsalts.com
MIT License
1.17k stars 380 forks source link

Pushover notifcations #55

Closed Stevaz913 closed 3 years ago

Stevaz913 commented 3 years ago

Added Pushover notification functionality option to trader.js

rolltidehero commented 3 years ago

Thanks, I'll give this a try when I get mine setup. :)

le-dawg commented 3 years ago

Lolz, someone did the work before. I should have checked 🤣 I will leave mine up for posterity anyway.

Yelles commented 3 years ago

hi @jsappme i really like your project, and this pull request too :) any reason to not merge this ?

Yelles commented 3 years ago

I feel that all this has to be refactored to fit the new notification system. 😅

dargmuesli commented 3 years ago

Yep, we now have a notification module into which this feature would need to be integrated.

dargmuesli commented 3 years ago

The trader script is now going to use Typescript (#111), which is unsupported by the pushover notification library used here. Either a different library has to be used or JavaScript support has to be enabled. Other than that a rewrite would be very quick and easy, now that all code is refactored. Closing this for now, but any new up-2-date approach is welcome!