search

bitcoinvsalts / react-native-firebase-starter

The ultimate React Native starter using Firebase, Mobx, CodePush, OneSignal made with ♥
http://jsapp.me
MIT License
287 stars 56 forks source link

.gitignore the `src/firebase.js` #9

Closed bartonhammond closed 7 years ago

bartonhammond commented 7 years ago

People shouldn't be checking in their firebase credentials. Update the Readme w/ instructions Provide a example to copy

bitcoinvsalts commented 7 years ago

I am okay with people using my firebase credentials for now. I want people to test this app as easy as possible.

bartonhammond commented 7 years ago

Maybe you should think about some misuse and you are stuck with the bill. And I for one don't want my credentials in the clear. You could put your credentials in the 'example'.

On Nov 20, 2016 11:47 AM, "JSapp.me" notifications@github.com wrote:

I am okay with people using my firebase credentials for now. I want people to test this app as easy as possible.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jsappme/react-native-firebase-starter/issues/9#issuecomment-261793045, or mute the thread https://github.com/notifications/unsubscribe-auth/ABORPIkmweKT_Yym6ql9icmUzArq62vrks5rAIfBgaJpZM4KwwKC .

bartonhammond commented 7 years ago

I thought I would share an experience that I hope you avoid. I once checked in the credentials for Amazon AWS. About 1 month later Amazon contacted me and informed me I had over $10,000 is charges! They were very helpful in educating me how to stop all these services that had been spun up and how to shut them all down. I had to work on this for days to finally get on top of it. Amazon was very nice in not making me pay for these charges. They said it appeared someone in Russia got the credentials. Evidently some criminal elements write bots to find credentials that they can use for a while and cut down their own cost. So be forewarned - bad things could happen in the hands of the wrong people.

On Sun, Nov 20, 2016 at 2:04 PM, Barton Hammond bartonhammond@gmail.com wrote:

Maybe you should think about some misuse and you are stuck with the bill. And I for one don't want my credentials in the clear. You could put your credentials in the 'example'.

On Nov 20, 2016 11:47 AM, "JSapp.me" notifications@github.com wrote:

I am okay with people using my firebase credentials for now. I want people to test this app as easy as possible.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jsappme/react-native-firebase-starter/issues/9#issuecomment-261793045, or mute the thread https://github.com/notifications/unsubscribe-auth/ABORPIkmweKT_Yym6ql9icmUzArq62vrks5rAIfBgaJpZM4KwwKC .