bitcoinjs-gui: colorman: load color definitions

killerstorm commented 11 years ago

Currently color definitions are embedded in code. There should be a way to load them via URL. Perhaps it should be stored in local storage.

(Integration with bitcoinjs-gui front-end is necessary.)

Bounty: 0.5 BTC

virtimus commented 11 years ago

got it compiled/instaled on my CentOS vm. Located defs in colorman.js

There should be only one source for defs defined or more ?

Proposed implementation : loading defs configurable via some (hardcoded/configured?) list of sources - ie:

/localdefsfile.js
http://someserver/otherdefs.js
web upload from file ?

Final defs merged from the list in a sequence.

killerstorm commented 11 years ago

Well, the general idea is that user should be able to add colors he is interested in, and list of colors should be preserved over page reloads (so that user does not need to add colors each time). Perhaps it should be persisted in same way wallets are. One way to do that is to add color definitions to bitcoinjs-gui wallet object so that they are persisted together.

There are three ways to deal with sources:

when user adds a source, store URL and load definitions from that source each time
import all definitions from that URL into a local store and forget URL itself
import definitions, but remember URL so that it is periodically polled and user is asked whether he wants to download new definitions

Let's not make it too complex from start, whatever is easiest will work.

But I guess there should be a default source of color definitions, for new users, so that they can try it right away without configuring anything. So, yeah, something like localdefsfile.js.

virtimus commented 11 years ago

OK understood.

So there will be I think two types of sources for a start:

local/predefined by local path (ie /somepath/localdefsfile.js);
user sources - defined dynamically via web by user (some simple GUI "add/remove/refresh source url's")

Both merged defs data and urls/paths will be stored with bitcoinjs-gui wallet and this will be loaded as current colorman.js/defs member.

That's now clear for me. I think I am able to do the task (I'm fresh to the project) I'll take it next week if still unassigned.

katuma commented 11 years ago

As much I hate to skip the line, it was kinda stopper for me.

https://github.com/katuma/bitcoinjs-gui/commit/3de776bd3a3f2cacba16fd94cd03fdd1fc71cb9f

bitcoinx / colored-coin-tools

bitcoinjs-gui: colorman: load color definitions #6