search

bitcoinxt / website

Website sources for bitcoinxt.software
6 stars 12 forks source link

Integrate jekyll-multiple-languages-plugin for translations #51

Closed EchterAgo closed 6 years ago

EchterAgo commented 6 years ago

@chaintip fixes #49

chaintip commented 6 years ago

If this pull request is merged to fix issue #49 first, @EchterAgo will claim the 0.02197916 BCH| ~ 33.43 USD bounty and all future tips to the issue.

EchterAgo commented 6 years ago

Had to upgrade Jekyll to 3.0 because the plugin needs it. Also the Russian translation seems to be a bit out of sync and needs some fixes.

EchterAgo commented 6 years ago

Test build:

testbuild.zip

dagurval commented 6 years ago

This is great work! Thanks for working on this.

I found one issue, comparing this and bitcoinxt.software, the layout on the FAQ is different. Also, the w3 validator found two errors on the FAQ page that weren't there before:

validator

Could you fix that?

EchterAgo commented 6 years ago

Thanks for the review, will fix it tomorrow. The original page also had some errors, but I'm sure I also introduced some new ones. What I still wonder is if it would be better to split the strings into pages. Like having a separate yml file for each page.

On Feb 18, 2018 03:03, "dagurval" notifications@github.com wrote:

This is great work! Thanks for working on this.

I found one issue, comparing this and bitcoinxt.software, the layout on the FAQ is different. Also, the w3 validator found two errors on the FAQ page that weren't there before:

[image: validator] https://user-images.githubusercontent.com/92707/36345123-8306ebc6-1425-11e8-9f77-8922800851a2.png

Could you fix that?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bitcoinxt/website/pull/51#issuecomment-366467629, or mute the thread https://github.com/notifications/unsubscribe-auth/AA4SeSXWI_kIS4YuEX5YCzLSTv6vtbtqks5tVzB1gaJpZM4SJUGe .

EchterAgo commented 6 years ago

Another thing I'm unsure about is my handling of the baseurl parameter in config.yml, I couldn't get it to work without changing it because otherwise I would get // in links and it would take the path as a hostname. Maybe something changed here in jekyll.

Also the Gemfile.lock, im not sure if I should check this change in. This is my first time working with Ruby.

On Feb 18, 2018 04:29, "Axel Gembe" axel@gembe.net wrote:

Thanks for the review, will fix it tomorrow. The original page also had some errors, but I'm sure I also introduced some new ones. What I still wonder is if it would be better to split the strings into pages. Like having a separate yml file for each page.

On Feb 18, 2018 03:03, "dagurval" notifications@github.com wrote:

This is great work! Thanks for working on this.

I found one issue, comparing this and bitcoinxt.software, the layout on the FAQ is different. Also, the w3 validator found two errors on the FAQ page that weren't there before:

[image: validator] https://user-images.githubusercontent.com/92707/36345123-8306ebc6-1425-11e8-9f77-8922800851a2.png

Could you fix that?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bitcoinxt/website/pull/51#issuecomment-366467629, or mute the thread https://github.com/notifications/unsubscribe-auth/AA4SeSXWI_kIS4YuEX5YCzLSTv6vtbtqks5tVzB1gaJpZM4SJUGe .

EchterAgo commented 6 years ago

Also, I didn't change the onboarding file as it is marked obsolete. If this is needed too I will do so ASAP.

On Feb 18, 2018 04:36, "Axel Gembe" axel@gembe.net wrote:

Another thing I'm unsure about is my handling of the baseurl parameter in config.yml, I couldn't get it to work without changing it because otherwise I would get // in links and it would take the path as a hostname. Maybe something changed here in jekyll.

Also the Gemfile.lock, im not sure if I should check this change in. This is my first time working with Ruby.

On Feb 18, 2018 04:29, "Axel Gembe" axel@gembe.net wrote:

Thanks for the review, will fix it tomorrow. The original page also had some errors, but I'm sure I also introduced some new ones. What I still wonder is if it would be better to split the strings into pages. Like having a separate yml file for each page.

On Feb 18, 2018 03:03, "dagurval" notifications@github.com wrote:

This is great work! Thanks for working on this.

I found one issue, comparing this and bitcoinxt.software, the layout on the FAQ is different. Also, the w3 validator found two errors on the FAQ page that weren't there before:

[image: validator] https://user-images.githubusercontent.com/92707/36345123-8306ebc6-1425-11e8-9f77-8922800851a2.png

Could you fix that?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bitcoinxt/website/pull/51#issuecomment-366467629, or mute the thread https://github.com/notifications/unsubscribe-auth/AA4SeSXWI_kIS4YuEX5YCzLSTv6vtbtqks5tVzB1gaJpZM4SJUGe .

EchterAgo commented 6 years ago

Oh, I'll also make a German translation as soon as this is merged.

On Feb 18, 2018 04:45, "Axel Gembe" axel@gembe.net wrote:

Also, I didn't change the onboarding file as it is marked obsolete. If this is needed too I will do so ASAP.

On Feb 18, 2018 04:36, "Axel Gembe" axel@gembe.net wrote:

Another thing I'm unsure about is my handling of the baseurl parameter in config.yml, I couldn't get it to work without changing it because otherwise I would get // in links and it would take the path as a hostname. Maybe something changed here in jekyll.

Also the Gemfile.lock, im not sure if I should check this change in. This is my first time working with Ruby.

On Feb 18, 2018 04:29, "Axel Gembe" axel@gembe.net wrote:

Thanks for the review, will fix it tomorrow. The original page also had some errors, but I'm sure I also introduced some new ones. What I still wonder is if it would be better to split the strings into pages. Like having a separate yml file for each page.

On Feb 18, 2018 03:03, "dagurval" notifications@github.com wrote:

This is great work! Thanks for working on this.

I found one issue, comparing this and bitcoinxt.software, the layout on the FAQ is different. Also, the w3 validator found two errors on the FAQ page that weren't there before:

[image: validator] https://user-images.githubusercontent.com/92707/36345123-8306ebc6-1425-11e8-9f77-8922800851a2.png

Could you fix that?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bitcoinxt/website/pull/51#issuecomment-366467629, or mute the thread https://github.com/notifications/unsubscribe-auth/AA4SeSXWI_kIS4YuEX5YCzLSTv6vtbtqks5tVzB1gaJpZM4SJUGe .

EchterAgo commented 6 years ago

Updated to fix the FAQ formatting issue.

EchterAgo commented 6 years ago

Fixed the validation problems. It is kind of a hacky fix because I didn't want to change the layout but still wanted to use the for loop in the file, which means I had to create an additional empty div/section element at the end :\

chaintip commented 6 years ago

Nice work @EchterAgo! Your pull request has been merged and the bounty of 0.02197916 BCH| ~ 33.16 USD has been sent to your wallet.

dagurval commented 6 years ago

What I still wonder is if it would be better to split the strings into pages. Like having a separate yml file for each page.

One file is fine IMO. The site doesn't have much content and we can change it later if it becomes an issue.

Also, I didn't change the onboarding file as it is marked obsolete. If this is needed too I will do so ASAP.

We just keep it to avoid link rot. It's linked to by various discussion forums and historically interesting. Best to leave without translation.

As for Gemfile.lock, I don't know.

I prefer your solution for the FAQ to keep the loop.

Thanks again for the fix! It's a big improvement.