search

bitcoinxt / website

Website sources for bitcoinxt.software
6 stars 12 forks source link

Fix title and description #59

Closed dagurval closed 6 years ago

dagurval commented 6 years ago

Partial revert of #58

dagurval commented 6 years ago

@EchterAgo I didn't notice it until the updates went live, but the change in #58 broke the title. I don't know if this is the correct way to fix it, but it works. Thoughts?

EchterAgo commented 6 years ago

I also just noticed this, will investigate.

On Feb 28, 2018 02:42, "dagurval" notifications@github.com wrote:

@EchterAgo https://github.com/echterago I didn't notice it until the updates went live, but the change in #58 https://github.com/bitcoinxt/website/pull/58 broke the title. I don't know if this is the correct way to fix it, but it works. Thoughts?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bitcoinxt/website/pull/59#issuecomment-369001200, or mute the thread https://github.com/notifications/unsubscribe-auth/AA4SeQtwLHykHp7s6Gk1PuJw6GzPzvJ6ks5tZFp2gaJpZM4SVhkr .

EchterAgo commented 6 years ago

I think this is a bug in jekyll-multiple-languages-plugin. After the revert it is exactly how the plugin recommends to do translation in templates:

https://github.com/Anthony-Gaudino/jekyll-multiple-languages-plugin#54-i18n-in-templates

Yet it warns that the keys are missing. Maybe we should provide a fallback title/description? Or just ignore the warning?

EchterAgo commented 6 years ago

Anyway, I think this revert is correct and should be merged.

dagurval commented 6 years ago

Thanks for investigating @EchterAgo