basic CI + target version bump to 3.7

bitcraft / pytmx

Python library to read Tiled Map Editor's TMX maps.

GNU Lesser General Public License v3.0

390 stars 81 forks source link

basic CI + target version bump to 3.7 #154

Closed jamesalbert closed 3 years ago

jamesalbert commented 3 years ago

Yo, I was in the neighborhood again. I didn't see any public CI so I added a basic workflow to run the tests against a few python versions. While doing so, to my understanding, these things stood out:

this line with an f-string prevents any python version <3.6 from working
this line with a future import prevents any python version <3.7 from working

so I bumped up the target version in the readme

lmk if I misunderstood anything about this or if y'all already have private CI!

bitcraft commented 3 years ago

no private ci, just haven't gotten around to it yet. thanks so much for adding the GH actions, that will be helpful! there are a couple other references to ancient python, ill remove them (i can recall the setup.py file, off hand, probably others) soon.

jamesalbert commented 3 years ago

@bitcraft yeah man, it's a lot of work. Happy to add these sorts of things in my off time. Yeah sounds good, early py3 to late py3 was a fun roller coaster 😄

Either way, I added dynamic dependencies in the workflow so it installs both pygame, one or the other, and none at all

bitcraft commented 3 years ago

Thanks so much! Feel free to bug me with feature requests or QOL fixes.