search

bitcraze / crazyflie-clients-python

Host applications and library for Crazyflie written in Python.
Other
307 stars 471 forks source link

Parameters not updated in UI #657

Closed krichardsson closed 1 year ago

krichardsson commented 1 year ago

Parameters that are updated from the firmware pushes the new value to the client. The problem is that the value in the parameter tab is not updated.

How to reproduce:

  1. Create a firmware app that sets a parameter
  2. Open the client and connect to the Crazyflie
  3. Open the parameter tab and look at the value of the parameter
  4. Let the firmware app update the parameter
  5. Observe the parameter value in the parameter tab

Observed behavior: The value in the parameter tab is not updated

Expected behavior: The value in the parameter tab is updated

knmcguire commented 1 year ago

This might be fixed already with this PR in the crazyflie? https://github.com/bitcraze/crazyflie-firmware/pull/1193

knmcguire commented 1 year ago

We will try this out if this is still an issue or not. It might have been fixed but we can't be sure.

krichardsson commented 1 year ago

The problem is not in the client, but both in the firmware and the python lib. The firmware was producing bad packets both for int and float parameter updates originating in the Crazyflie. The lib was completely missing functionality for handling parameter updates from the Crazyflie!

The client was OK already, parameter values are updated live in the list, but not in the section where new parameter values are set.

knmcguire commented 1 year ago

tested! and this is fixed now. Thanks!