Closed simondlevy closed 12 months ago
I'm afraid that this PR has the same issue... This is not something that we can merge I'm afraid.
Before removing this and starting a new PR, please look into the toolbelt. Here you can run the same checks that are being done in the CI.
Opening, closing, and opening PRs again will generate a lot of noise on our support channels. If you are unfamiliar of generating PRs, let's open up a discussion first and let's strategies the PRs first. These seem quite big and to reduce the chance of it not being accepted by me or my colleagues.
let's talk battle plan here ! https://github.com/orgs/bitcraze/discussions/863
Second PR attempt.