bitcraze / crazyflie2-ios-client

The Crazyflie 2.0 iOS client
36 stars 36 forks source link

RFC: Convert the full app to Swift #12

Closed ataffanel closed 1 year ago

ataffanel commented 8 years ago

This is a request for comment, I am not experienced enough in iOS development to really have an opinion on that.

The Crazyflie iOS client has been started the same month Swift was announced so it felt risky starting directly in Swift (and no tutorial where updated yet). However nowadays I feel more confortable coding in Swift.

So the question is: is there any interest in converting the app in Swift and does anyone has an idea of the complexity of the task? There is not much left in objective-C but it is the central part (the view controllers).

EMart002 commented 7 years ago

Hi @ataffanel, just to let you know, i'm currently working on the swift3 issues #12 and #10

ataffanel commented 7 years ago

Hi @EMart002, sounds good thanks for the heads up! Tell me if you hit any problem I can help with.

EMart002 commented 7 years ago

Hi @ataffanel, i think i'll be done tonight with the implementation in swift. Thereafter i'll create a pull request. One thing: i ususally fly the crazyflie with both blue leds facing to me. Am i doing it correct? This is an important information for me so i can test it the correct way :)

ataffanel commented 7 years ago

Yes, the two blue LED are on the back of the Crazyflie, so they should be facing you when flying.

That is good news, I look forward to testing it!

ataffanel commented 7 years ago

Mostly implemented thanks to @EMart002. The only part left is to find a way to pack/unpack the binary radio packets in swift.

valeriyvan commented 1 year ago

With #33 all app is Swift now. I think this issue could be closed as implemented.

ataffanel commented 1 year ago

This is correct, I can close the issue. Thanks for the help!