Size naming - Githubissues

bitcrowd / bitstyles

A complete design system, with base styles and components, built in Sass using CSS variables

https://bitcrowd.github.io/bitstyles

ISC License

16 stars 0 forks source link

Size naming #666

Closed planktonic closed 2 years ago

planktonic commented 2 years ago

A couple of issues with our current naming:

gap sizes and padding/margin sizes don’t match. This was a decision taken on the basis that a “large” grid gap is xxxl, but e.g. a large icon could be xl — the name of component’s size is relative to that component instead of to the global sizing scale. With the rise of utility class usage, that’s confusing tho, and means developers need to look up e.g. what size a grid gap is in order to match it with an icon, or padding on another element.
this is probably a good time to switch to using l, xl, 2xl, 3xl etc. instead of the current l, xl, xxl, xxxl

ArinzeJeffrey-droid commented 2 years ago

@planktonic Would I have to rebase off this to start working on this issue?

planktonic commented 2 years ago

@ArinzeJeffrey-droid these should be separate tbh — no need to rebase :)