[#752] Update Dropdown component - Githubissues

bitcrowd / bitstyles

A complete design system, with base styles and components, built in Sass using CSS variables

https://bitcrowd.github.io/bitstyles

ISC License

16 stars 0 forks source link

[#752] Update Dropdown component #753

Closed planktonic closed 1 year ago

planktonic commented 1 year ago

Fixes #752

Changes

Uses the Button component in the dropdown stories, and adds a Dropdown component for use in these stories
Updates appearance of dropdowns to match Zeplin
button--menu now has no border-radius

Looks like

Screenshot 2023-04-04 at 14 23 24

How to QA Visual changes

git checkout main
git pull
git checkout feature/752-update-dropdown-component
yarn
yarn storybook
navigate to atoms/dropdown

Check:

[x] The appearance matches the zeplin designs.
[x] The documentation for this component is correct, understandable, and up-to-date.

How to QA code changes

[x] The documentation for this component is correct, understandable, and up-to-date.
[x] The component makes good use of CSS custom properties to simplify creating variants (or doesn’t have variants).
[x] Everything that should be a variable, is.

Preflight checks

PR author to check, and delete if not applicable:

[x] Storybook documentation has been updated
[x] Fixtures in test/scss/ have been updated
[x] Your changes have been added to the unreleased section of CHANGELOG.md

planktonic commented 1 year ago

@ed-eva thanks! I’ve addressed all your feedback (with the same caveat about shadows as in https://github.com/bitcrowd/bitstyles/pull/751#issuecomment-1495538276)