bitcrowd / bitstyles_phoenix

A collection of Elixir phoenix helpers for bitstyles
ISC License
12 stars 0 forks source link

Upgrade bitstyles to 5.0.1 #125

Closed angelikatyborska closed 4 months ago

angelikatyborska commented 7 months ago

Resolves https://github.com/bitcrowd/bitstyles_phoenix/issues/122

Note that the sidebar example in 4.3.0 will look weird because it contains a lot of example content that's written with attributes supported in 5.0.0 only.

Also note that the class a-button is now display: flex instead of display: inline-flex and now <a>s with that class look different than <button>s with that class due to different default widths of the two elements. This discrepancy would need to be fixed on a project level where bitstyles-phoenix is used, by something like a { width: fit-content } or so. Or just be using those elements inside appropriate flex/grid containers.

List of changes:

angelikatyborska commented 7 months ago

Waiting for bitstyles v5.0.0 to be republished as v5.0.1 with the correct CSS build.

angelikatyborska commented 4 months ago

Note to self: fix heading with list, the list should not look like a list Note to self: fix sidebar border color Note to self: fix tabs, the list should not look like a list

Edit: done