search

bitcrowd / bitstyles_phoenix

A collection of Elixir phoenix helpers for bitstyles
ISC License
12 stars 0 forks source link

Upgrade bitstyles to 6.0.0 #127

Closed angelikatyborska closed 3 days ago

angelikatyborska commented 2 months ago

Based on top of https://github.com/bitcrowd/bitstyles_phoenix/pull/125

Resolves https://github.com/bitcrowd/bitstyles_phoenix/issues/110 https://github.com/bitcrowd/bitstyles_phoenix/issues/108 https://github.com/bitcrowd/bitstyles_phoenix/issues/109

angelikatyborska commented 2 months ago

@andreasknoepfle I ran into a surprise: the class replacements from the classnames helper do not chain... For example, there was this chain of renaming:

u-fg-grayscale-dark-2 (6.0.0) -> u-fg-text-darker (5.0.0) -> u-fg-gray-50 (4.3.0)

If I render a component that uses the class u-fg-grayscale-dark-2, and I render it for v4.3.0, it ends up with the class u-fg-text-darker instead of u-fg-gray-50 because replacements are applied backwards 🤔 (first from 5.0.0 -> 4.3.0, then from 6.0.0 -> 5.0.0).

angelikatyborska commented 3 weeks ago

I ran into a surprise: the class replacements from the classnames helper do not chain... For example, there was this chain of renaming:

Will be resolved by merging https://github.com/bitcrowd/bitstyles_phoenix/pull/134 first

angelikatyborska commented 5 days ago

I'm pretty confident of those changes because we've been using them in the IDA backend with no hiccups