bitcrowd / bitstyles_phoenix

A collection of Elixir phoenix helpers for bitstyles
ISC License
12 stars 0 forks source link

phoenix_html v4 compatibility #130

Closed angelikatyborska closed 4 months ago

angelikatyborska commented 4 months ago

Resolves https://github.com/bitcrowd/bitstyles_phoenix/issues/129

Goal: make bitstyles_phoenix work in any combination of phoenix_live_view versions 18 to 20, and phoenix_html versions 3 to 4

Replacements

CI changes

https://hexdocs.pm/elixir/library-guidelines.html#dependency-handling recommends:

The best practice of handling mix.lock file therefore would be to keep it in VCS, and run two different Continuous Integration (CI) workflows: the usual deterministic one, and another one, that starts with mix deps.unlock --all and always compiles your library and runs tests against latest versions of dependencies. The latter one might be even run nightly or otherwise recurrently to stay notified about any possible issue in regard to dependencies updates.

Running tests with unlocked deps would detect that bitstyles_phoenix does not work with the newest phoenix_html version because there was no version specification for this dependency in the mix file.

Other notes

angelikatyborska commented 4 months ago

The regular unit test job runs phoenix_html v3, the one with unlocked deps runs v4. Both succeeding meaning that I achieved the task 🎉