Closed lumenlunae closed 5 months ago
thx... the version()
call in Template
is actually quite annoying. Going to make that lazy at least so people have a way to work around this issue.
also going to remove the chromedriver
Ah sorry for that! And thanks!
Add two filenames from the new Heroku Chrome buildpack https://blog.heroku.com/improved-browser-testing-on-heroku-with-chrome
The previous buildpacks I tried using Gigalixir didn't work: https://github.com/heroku/heroku-buildpack-google-chrome https://github.com/hermantolim/gigalixir-buildpack-google-chrome
However, the new "improved-browser-testing-on-heroku-with-chrome" installs as "chrome" and "chromedriver"
I tried just using
chrome_executable: chrome
to avoid a PR. Things I noticed with that:I believe
do_version
callsexecutable()
without passing in the config options, sochrome_executable
isn't being read.-- but that's for another PR. This navigating took away 😅 Hope this helps!