search

bitcrowd / chromic_pdf

Convenient HTML to PDF/A rendering library for Elixir based on Chrome & Ghostscript
Apache License 2.0
409 stars 37 forks source link

Enable connecting over ipv6 #313

Closed sasikumar87 closed 2 months ago

sasikumar87 commented 2 months ago

Changes to enable connecting over ipv6

maltoe commented 2 months ago

Hey @sasikumar87

may I ask what do you need this for?

sasikumar87 commented 2 months ago

Hi @maltoe, I am trying to deploy chrome on a fly.io machine in private mode. Fly machine's ipv4 is always public. To make it private, I must use IPv6. Ref : https://fly.io/docs/networking/app-services/#private-flycast-apps-2

Though I tested it further and found websokex also needs change at :gen_tcp.connect to make websockets connect over ipv6. https://github.com/Azolo/websockex/blob/v0.4.3/lib/websockex/conn.ex#L156

So the changes in this PR alone is not sufficient without websockex changes.

sasikumar87 commented 2 months ago

I'll close this for now, as websockex also needs change.

walter commented 2 months ago

@sasikumar87 I'm not seeing a PR or issue on websockex with the required change for ipv6. Is there something in the works to support it?

sasikumar87 commented 2 months ago

@walter I just raised an issue in websockex https://github.com/Azolo/websockex/issues/131 .