bitcrowd / chromic_pdf

Convenient HTML to PDF/A rendering library for Elixir based on Chrome & Ghostscript
Apache License 2.0
423 stars 38 forks source link

Add ability to remove default args via config #314

Closed walter closed 4 months ago

walter commented 4 months ago

When trying to use chromic_pdf in combination with pages that contain WebGL images, there are two default args in ChromeRunner that prevent it from working.

Based on my experimentation, simply overriding these in :chrome_args is not enough. Once they are declared, they can't be overridden by further switches.

Instead of just taking these out, and maybe break other people's projects, I think adding the ability to remove the args via configuration is a more useful feature.

walter commented 4 months ago

Hi @walter

Had a few stylistic nitpicks still. If you don't want to continue working on this, I can also merge it in and refactor afterwards. As you prefer.

Thanks again!

Thanks for the feedback. Jibes with some thoughts I had myself, but was distracted by other work. I hadn't used List.wrap before, nice!

Have a look at latest and let me know if there is anything else.

maltoe commented 4 months ago

Thanks again!

maltoe commented 4 months ago

Released as v1.16.1