Fix jira URL prefixes to work with new jira boards

bitcrowd / tickety-tick

A browser extension that helps you name branches and write better commit messages

MIT License

57 stars 10 forks source link

Fix jira URL prefixes to work with new jira boards #217

Closed tessi closed 4 years ago

tessi commented 4 years ago

The JIRA board URLS changed for new JIRA boards. They now contain optional trailing slashes and also allow further nested routes. Examples:

/jira/software/projects/ABCD/boards/7
/jira/software/projects/ABCD/boards/7/backlog

Where before, only this URL was recognized:

/jira/software/projects/BCHP/boards/7/

Closes #195.

pmeinhardt commented 4 years ago

Is this a different problem from: https://github.com/bitcrowd/tickety-tick/pull/216?

tessi commented 4 years ago

Is this a different problem from: #216?

This is the exact issue i fixed - by not scanning (and removing) the prefix path correctly that weird URL from #216 gets built. Since our regexp is more open to change now, we catch this problem and use the proper API endpoint again.

tessi commented 4 years ago

@pmeinhardt true that, added tests. Actually one of the existing tests passed although the wrong jira base_url was called. I added a check against which API URL is called to the relevant tests.