Closed klappradla closed 4 years ago
PS: the adaption of the build-icons
script was only blindly throwing things in with only half my brain on... We can probably revert most of it π
Done now @pmeinhardt π§βπ Had lots of interruptions, sorry π
Million thanks for the review by the way! Really neat points, love the outcome of this π€
This addresses a point @bitboxer mentioned in #176: the dark icon may be "too dark" when using a dark theme or macOS' dark mode.
This is a suggestion on how we could support this (at least for Firefox) π¦ using the
theme_icons
property inbrowser_action
.By configuring this, we can show a light menu icon when users use the dark Firefox theme (or macOS "dark mode").
I also - this is only an experiment β οΈ - changed the colors to match the ones recommended in Firefox' styleguide on iconography ποΈ
The two colors are:
This would look like this:
dark π΄
light π³οΈ
The icon changes automatically without adding additional scripts:![firefox](https://user-images.githubusercontent.com/3491815/79483114-1c40d900-8012-11ea-99c3-8686eda30651.gif)
NOTE It would also be possible to support this behavior in Chrome. I could only reproduce this via JS and having additional events in the
background.js
... I personally find the price too high for just the color of the icon for now.I could - if people are interested - play around with the Chrome approach in a separate PR though. Happy to do that π€