search

bitcrowd / tickety-tick

A browser extension that helps you name branches and write better commit messages
MIT License
57 stars 10 forks source link

Adjust tab flow in new design #231

Closed klappradla closed 4 years ago

klappradla commented 4 years ago

In the new compact design introduced in #221, the tabing workflow feels a bit off for cases where only a single ticket is matched (which may assumed to be the default case for most trackers): the disabled select field still gets the focus on the 3rd press of the tab key.

Firefox however does not indicate the focus. Plus there is not really such a huge point in focussing the disabled field 🤔 . Still, people may get the impression that the popup lost focus all together, while in fact another press of the tab key would just bring them back.

See the two scenarios for a comparison:

Multiple Tickets

Screenshot 2020-04-29 at 14 53 30

Single Ticket

Screenshot 2020-04-29 at 14 53 42

One way to make this more intuitive could be to not make the select tabable at all when it's disabled? What do you think?

pmeinhardt commented 4 years ago

Oh wow. Firefox tab-selects disabled elements. Didn't expect that. 👀 Thanks @klappradla ❤️

klappradla commented 4 years ago

Experimenting around with this a bit, it actually seems to be a false alarm 🙈.

The focus is not on the disabled select, but on either the whole popup or outside which is still the same behavior as for the currently released version.

TL;DR the disabled select input is not tab-selected 👍

klappradla commented 4 years ago

FYI: the active element is the body then 🤷